Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace remote for setting auto-open pref #653

Merged

Conversation

bmulholland
Copy link
Collaborator

One of the last usages of remote, which generally isn't recommended

@bmulholland bmulholland force-pushed the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch from 369befe to 4a5ffd9 Compare October 4, 2023 09:23
@bmulholland
Copy link
Collaborator Author

bmulholland commented Oct 4, 2023

Coveralls is right, we don't test the code pulled into main.js for IPC communication. Is it worth it, though? The unit test would just mock out the call, so I'm not really sure what value it would provide -- what's the test actually testing?

Base automatically changed from 10-04-chore_Replace_remote_for_hiding_window to main October 10, 2023 00:16
@bmulholland bmulholland force-pushed the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch from 4a5ffd9 to f0ec1cc Compare October 10, 2023 08:42
@bmulholland bmulholland force-pushed the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch from f0ec1cc to 0fc4a21 Compare October 13, 2023 07:23
@afonsojramos afonsojramos merged commit 26b1fa5 into main Oct 18, 2023
6 of 7 checks passed
@afonsojramos afonsojramos deleted the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch October 18, 2023 13:30
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants